chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc - Issue 1140023002: Code Refactor and making function static in frame_navigation_state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc

Issue 1140023002: Code Refactor and making function static in frame_navigation_state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_navigation/frame_navigation_state.h ('K') | « chrome/browser/extensions/api/web_navigation/frame_navigation_state.h ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.h » ('j') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc

diff --git a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc

index 37764cb0064a8f70f43de14d1849aebcb8ec84b3..44ac6e00f2a983274163ba2974a6f1c35a4b6c3e 100644

--- a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc

+++ b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc

@@ -47,7 +47,8 @@ bool FrameNavigationState::CanSendEvents(

return IsValidUrl(it->second.url);

}

-bool FrameNavigationState::IsValidUrl(const GURL& url) const {

+// static

+bool FrameNavigationState::IsValidUrl(const GURL& url) {

for (unsigned i = 0; i < arraysize(kValidSchemes); ++i) {

if (url.scheme() == kValidSchemes[i])

return true;