[Password manager] Temporarily add some CHECKs to investigate a crash

[Password manager] Temporarily add some CHECKs to investigate a crash

Add some CHECKs to see if some of the hypotheses in http://crbug.com/486931#c3 (however unlikely they seem) could be right.
This is in line with https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-.

BUG=486931
Committed: https://crrev.com/3e966cacd118b489ab195f03446812c7eaedfc8f
Cr-Commit-Position: refs/heads/master@{#329393}

[vabr (Chromium), 2015-05-12 10:06:54]

vabr@chromium.org changed reviewers:
+ mkwst@chromium.org

[vabr (Chromium), 2015-05-12 10:06:55]

Hi Mike,
PTAL.

Thanks!
Vaclav

[Mike West, 2015-05-12 11:06:21]

LGTM. Users love crashes!

[vabr (Chromium), 2015-05-12 11:19:58]

On 2015/05/12 11:06:21, Mike West wrote:
> LGTM. Users love crashes!

The hope here is that this will not introduce new crashes, but make the existing
ones easier to diagonse.

Thanks!
Vaclav

[vabr (Chromium), 2015-05-12 11:20:01]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-05-12 11:20:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139863003/1

[commit-bot: I haz the power, 2015-05-12 12:05:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-12 12:06:25]

Patchset 1 (id:??) landed as
https://crrev.com/3e966cacd118b489ab195f03446812c7eaedfc8f
Cr-Commit-Position: refs/heads/master@{#329393}

[vabr (Chromium), 2016-01-26 13:25:22]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1639643003/ by vabr@chromium.org.

The reason for reverting is: The associated bug got closed, the crash is no
longer observed since version 43, so the checks are overdue to be removed..

[vabr (Chromium), 2016-01-26 14:41:42]

On 2016/01/26 13:25:22, vabr (Chromium) wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1639643003/ by mailto:vabr@chromium.org.
> 
> The reason for reverting is: The associated bug got closed, the crash is no
> longer observed since version 43, so the checks are overdue to be removed..

The revert actually landed as https://codereview.chromium.org/1636813003/, as I
had to rebase anyway.