Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/autofill/core/common/password_form.cc

Issue 1139863003: [Password manager] Temporarily add some CHECKs to investigate a crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/common/password_form.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/password_form.cc
diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc
index 110a08e0e1cd320ff51740d8a7b80da0e1fe0b72..41ca1fc6c5069150568bcb8ca680b1d7d67f5309 100644
--- a/components/autofill/core/common/password_form.cc
+++ b/components/autofill/core/common/password_form.cc
@@ -76,13 +76,17 @@ PasswordForm::PasswordForm()
generation_upload_status(NO_SIGNAL_SENT),
skip_zero_click(false),
layout(Layout::LAYOUT_OTHER),
- was_parsed_using_autofill_predictions(false) {
+ was_parsed_using_autofill_predictions(false),
+ is_alive(true) {
}
PasswordForm::~PasswordForm() {
+ CHECK(is_alive);
+ is_alive = false;
}
bool PasswordForm::IsPublicSuffixMatch() const {
+ CHECK(is_alive);
return !original_signon_realm.empty();
}
« no previous file with comments | « components/autofill/core/common/password_form.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698