Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3859)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1139863003: [Password manager] Temporarily add some CHECKs to investigate a crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/common/password_form.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_state.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc
index 457b6ecc6838898f95ed668a2acb4e70abe49a58..d4e63413dee78d1297ea29bc78a6f65eca40b827 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc
@@ -149,7 +149,8 @@ void ManagePasswordsState::OnAutomaticPasswordSave(
void ManagePasswordsState::OnPasswordAutofilled(
const PasswordFormMap& password_form_map) {
- DCHECK(!password_form_map.empty());
+ // TODO(vabr): Revert back to DCHECK once http://crbug.com/486931 is fixed.
+ CHECK(!password_form_map.empty());
ClearData();
if (password_form_map.begin()->second->IsPublicSuffixMatch()) {
// Don't show the UI for PSL matched passwords. They are not stored for this
« no previous file with comments | « no previous file | components/autofill/core/common/password_form.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698