Use the wrapped context to inflate the selection menu.

Use the wrapped context to inflate the selection menu.

BUG=486734
Committed: https://crrev.com/30282d705741effa0b53783b2e88bfb5e02b2d15
Cr-Commit-Position: refs/heads/master@{#329648}

[Tobias Sargeant, 2015-05-12 10:00:32]

tobiasjs@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2015-05-12 10:08:04]

lgtm

[Tobias Sargeant, 2015-05-12 10:09:02]

The CQ bit was checked by tobiasjs@chromium.org

[commit-bot: I haz the power, 2015-05-12 10:09:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139743003/1

[commit-bot: I haz the power, 2015-05-12 10:14:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-12 10:14:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tobias Sargeant, 2015-05-12 10:20:49]

tobiasjs@chromium.org changed reviewers:
+ jdduke@chromium.org

[jdduke (slow), 2015-05-13 15:24:43]

https://codereview.chromium.org/1139743003/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java
(right):

https://codereview.chromium.org/1139743003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java:145:
new MenuInflater(getContext()).inflate(R.menu.select_action_menu, menu);
I can't say I understand why this fixes things, but lgtm I guess?

[jdduke (slow), 2015-05-13 15:26:54]

https://codereview.chromium.org/1139743003/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java
(right):

https://codereview.chromium.org/1139743003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java:145:
new MenuInflater(getContext()).inflate(R.menu.select_action_menu, menu);
On 2015/05/13 15:24:42, jdduke wrote:
> I can't say I understand why this fixes things, but lgtm I guess?

Nevermind, I see now, still lgtm.

[jdduke (slow), 2015-05-13 15:26:57]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2015-05-13 15:27:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139743003/1

[Tobias Sargeant, 2015-05-13 15:27:46]

On 2015/05/13 15:24:43, jdduke wrote:
>
https://codereview.chromium.org/1139743003/diff/1/content/public/android/java...
> File
>
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java
> (right):
> 
>
https://codereview.chromium.org/1139743003/diff/1/content/public/android/java...
>
content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java:145:
> new MenuInflater(getContext()).inflate(R.menu.select_action_menu, menu);
> I can't say I understand why this fixes things, but lgtm I guess?

Explanation, for the record, is that the ActionMode gets a context from another
point in the view hierarchy (not the WebView), which ends up being the Activity
context. Because the WebView has never seen the Activity context (having been
constructed with the Application context) it hasn't had the asset path added to
it, and the resource load fails.

[commit-bot: I haz the power, 2015-05-13 16:13:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-13 16:14:51]

Patchset 1 (id:??) landed as
https://crrev.com/30282d705741effa0b53783b2e88bfb5e02b2d15
Cr-Commit-Position: refs/heads/master@{#329648}