android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java - Issue 1139743003: Use the wrapped context to inflate the selection menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

Issue 1139743003: Use the wrapped context to inflate the selection menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java » ('j') | content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

index 5bae06810c4f105d3a641f7efe183705b24abda1..8412516ef7bce84dde6e2b538a3d2c40e44baac0 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

@@ -393,8 +393,7 @@ public class WebViewContentsClientAdapter extends AwContentsClient {

TraceEvent.begin("WebViewContentsClientAdapter.startActionMode");

if (TRACE) Log.d(TAG, "startActionMode");

if (floating) return null;

- ActionMode.Callback callback =

- new SelectActionModeCallback(view.getContext(), actionHandler);

+ ActionMode.Callback callback = new SelectActionModeCallback(mContext, actionHandler);

ActionMode actionMode = view.startActionMode(callback);

return actionMode != null ? new SelectActionMode(actionMode) : null;

} finally {