content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java - Issue 1139743003: Use the wrapped context to inflate the selection menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java

Issue 1139743003: Use the wrapped context to inflate the selection menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java b/content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java

index 7984cdc13ba5c34000aec5ae5acb428625f79cee..3a88b64b8b4c7245df616053eed15d044248ce6b 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java

@@ -9,6 +9,7 @@ import android.content.Context;

import android.graphics.Rect;

import android.view.ActionMode;

import android.view.Menu;

+import android.view.MenuInflater;

import android.view.MenuItem;

import android.view.View;

@@ -141,7 +142,7 @@ public class SelectActionModeCallback implements ActionMode.Callback {

}

private void createActionMenu(ActionMode mode, Menu menu) {

- mode.getMenuInflater().inflate(R.menu.select_action_menu, menu);

+ new MenuInflater(getContext()).inflate(R.menu.select_action_menu, menu);

jdduke (slow) 2015/05/13 15:24:42 I can't say I understand why this fixes things, bu

jdduke (slow) 2015/05/13 15:26:53 Nevermind, I see now, still lgtm.

if (mIsInsertion) {

menu.removeItem(R.id.select_action_menu_select_all);

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java ('k') | no next file » | no next file with comments »