Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1139743002: GLProgramsTest 3.0 (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@randbatch11
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more cleanup #

Patch Set 3 : more #

Total comments: 2

Patch Set 4 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -122 lines) Patch
M include/gpu/GrTestUtils.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrBatchTest.cpp View 1 2 1 chunk +17 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTestUtils.cpp View 1 2 3 2 chunks +23 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 4 chunks +14 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 9 chunks +32 lines, -87 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-12 14:57:42 UTC) #2
joshualitt
On 2015/05/12 14:57:42, joshualitt wrote: > ptal ping
5 years, 7 months ago (2015-05-13 13:18:05 UTC) #3
robertphillips
https://codereview.chromium.org/1139743002/diff/40001/src/gpu/GrOvalRenderer.cpp File src/gpu/GrOvalRenderer.cpp (right): https://codereview.chromium.org/1139743002/diff/40001/src/gpu/GrOvalRenderer.cpp#newcode2096 src/gpu/GrOvalRenderer.cpp:2096: bool useCoverageAA = random->nextBool(); Why not TestRectSimple? https://codereview.chromium.org/1139743002/diff/40001/tests/GLProgramsTest.cpp File ...
5 years, 7 months ago (2015-05-13 13:47:23 UTC) #4
robertphillips
otherwise lgtm
5 years, 7 months ago (2015-05-13 13:50:55 UTC) #5
bsalomon
On 2015/05/13 13:50:55, robertphillips wrote: > otherwise lgtm lgtm too
5 years, 7 months ago (2015-05-13 13:56:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139743002/60001
5 years, 7 months ago (2015-05-13 15:45:05 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 15:51:55 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6c891107ce0a8431f2327cb8b2f1bfd363cabbbe

Powered by Google App Engine
This is Rietveld 408576698