Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 113943003: [CSS Grid] Introduce an explicit type for resolved grid positions (Closed)

Created:
6 years, 11 months ago by Xan
Modified:
6 years, 7 months ago
Reviewers:
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@to-land-zero
Visibility:
Public.

Description

[CSS Grid] Introduce an explicit type for resolved grid positions We were using simple size_t integers to represent resolved grid positions in our internal data structures. This change allows us to clarify the code, avoid potential off by one mistakes, and move some of the ugliest bits of the resolving code to a central place. This is a transition patch, so there's no attempt at making the code pretty. In particular we just provide a setIntegerPosition()/integerPosition() pair, that are used throughout the code to set/get the resolved positions. A follow-up patch will move the rest of the resolver code in RenderGrid to the GridResolvedPosition class, and we should be able to completely remove those methods. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -128 lines) Patch
M Source/core/css/CSSGridTemplateValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderGrid.h View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 11 chunks +31 lines, -31 lines 0 comments Download
M Source/core/rendering/style/GridCoordinate.h View 4 chunks +19 lines, -18 lines 0 comments Download
M Source/core/rendering/style/GridPosition.h View 2 chunks +0 lines, -21 lines 0 comments Download
A + Source/core/rendering/style/GridResolvedPosition.h View 2 chunks +37 lines, -46 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Xan
In the end I decided to ignore all the extra operators to make the code ...
6 years, 11 months ago (2014-01-02 12:31:23 UTC) #1
svillar
6 years, 11 months ago (2014-01-13 07:57:00 UTC) #2
Manuel Rego
6 years, 8 months ago (2014-04-09 20:54:49 UTC) #3
I guess we can close this, as it has been already committed as part of
https://codereview.chromium.org/166623002/

Powered by Google App Engine
This is Rietveld 408576698