Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: Source/core/css/CSSGridTemplateValue.cpp

Issue 113943003: [CSS Grid] Introduce an explicit type for resolved grid positions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@to-land-zero
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/parser/BisonCSSParser-in.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSGridTemplateValue.cpp
diff --git a/Source/core/css/CSSGridTemplateValue.cpp b/Source/core/css/CSSGridTemplateValue.cpp
index d1ad1d8d056589c1e09ff10b8b2d7489f5276c09..f8114026a519927d9efff20198d5650011e1408f 100644
--- a/Source/core/css/CSSGridTemplateValue.cpp
+++ b/Source/core/css/CSSGridTemplateValue.cpp
@@ -52,14 +52,14 @@ static String stringForPosition(const NamedGridAreaMap& gridAreaMap, size_t row,
NamedGridAreaMap::const_iterator end = gridAreaMap.end();
for (NamedGridAreaMap::const_iterator it = gridAreaMap.begin(); it != end; ++it) {
const GridCoordinate& coordinate = it->value;
- if (row >= coordinate.rows.initialPositionIndex && row <= coordinate.rows.finalPositionIndex)
+ if (row >= coordinate.rows.initialPositionIndex.integerPosition() && row <= coordinate.rows.finalPositionIndex.integerPosition())
candidates.append(it->key);
}
end = gridAreaMap.end();
for (NamedGridAreaMap::const_iterator it = gridAreaMap.begin(); it != end; ++it) {
const GridCoordinate& coordinate = it->value;
- if (column >= coordinate.columns.initialPositionIndex && column <= coordinate.columns.finalPositionIndex && candidates.contains(it->key))
+ if (column >= coordinate.columns.initialPositionIndex.integerPosition() && column <= coordinate.columns.finalPositionIndex.integerPosition() && candidates.contains(it->key))
return it->key;
}
« no previous file with comments | « no previous file | Source/core/css/parser/BisonCSSParser-in.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698