Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in ui/events

Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in ui/events & ui/views

BUG=457697
Committed: https://crrev.com/c1bcfae190a66a5f177542d990412b9cd48988f4
Cr-Commit-Position: refs/heads/master@{#331618}

[d.samantaray, 2015-05-14 07:50:03]

d.samantaray@samsung.com changed reviewers:
+ gcasto@chromium.org, vabr@chromium.org

[d.samantaray, 2015-05-14 07:50:04]

I have uploaded the patch please review.

[d.samantaray, 2015-05-15 03:25:45]

I have uploaded the patch,please review.
https://codereview.chromium.org/1138993007/

[vabr (Chromium), 2015-05-15 08:25:56]

Please choose appropriate OWNERS reviewers
(https://www.chromium.org/developers/owners-files).

[d.samantaray, 2015-05-15 08:47:12]

d.samantaray@samsung.com changed reviewers:
+ sadrul@chromium.org, sky@chromium.org
- gcasto@chromium.org, vabr@chromium.org

[d.samantaray, 2015-05-15 08:47:13]

I have uploaded the patch. Please review.
https://codereview.chromium.org/1138993007/

[sadrul, 2015-05-15 15:46:05]

. The failure in the ozone bot look relevant. Please fix (the fix is probably to
use a ScopedVector in TouchNoiseFilter).

. Please update the CL description to mention ui/views too

[d.samantaray, 2015-05-21 07:09:39]

Incorporated review comments.
Please review.

[d.samantaray, 2015-05-22 07:55:20]

d.samantaray@samsung.com changed reviewers:
- sky@chromium.org

[d.samantaray, 2015-05-22 07:55:21]

Incorporated the changes.
Please review

[sadrul, 2015-05-22 16:08:14]

On 2015/05/15 15:46:05, sadrul wrote:
> . The failure in the ozone bot look relevant. Please fix (the fix is probably
to
> use a ScopedVector in TouchNoiseFilter).
> 
> . Please update the CL description to mention ui/views too

I see that you have removed the ozone changes. Would you mind fixing those and
adding them back?

[d.samantaray, 2015-05-25 04:34:53]

On 2015/05/22 16:08:14, sadrul wrote:
> On 2015/05/15 15:46:05, sadrul wrote:
> > . The failure in the ozone bot look relevant. Please fix (the fix is
probably
> to
> > use a ScopedVector in TouchNoiseFilter).
> > 
> > . Please update the CL description to mention ui/views too
> 
> I see that you have removed the ozone changes. Would you mind fixing those and
> adding them back?

I have submitted the same in another patch.
https://codereview.chromium.org/1154813002/

[sadrul, 2015-05-25 04:42:45]

On 2015/05/25 04:34:53, d.samantaray wrote:
> On 2015/05/22 16:08:14, sadrul wrote:
> > On 2015/05/15 15:46:05, sadrul wrote:
> > > . The failure in the ozone bot look relevant. Please fix (the fix is
> probably
> > to
> > > use a ScopedVector in TouchNoiseFilter).
> > > 
> > > . Please update the CL description to mention ui/views too
> > 
> > I see that you have removed the ozone changes. Would you mind fixing those
and
> > adding them back?
> 
> I have submitted the same in another patch.
> https://codereview.chromium.org/1154813002/

Both the CLs are small enough that it would be better to merge both into one CL.
(and that CL does not address the TouchNoiseFilter change).

[d.samantaray, 2015-05-25 06:45:31]

I have added the ozone changes and added them back, please review.

[d.samantaray, 2015-05-26 03:13:01]

I have added the ozone changes, Please review.

[sadrul, 2015-05-26 03:21:04]

On 2015/05/26 03:13:01, d.samantaray wrote:
> I have added the ozone changes, Please review.

Looks like you also removed the rest of ui/events/ and ui/views/ changes?

[d.samantaray, 2015-05-26 04:06:49]

On 2015/05/26 03:21:04, sadrul wrote:
> On 2015/05/26 03:13:01, d.samantaray wrote:
> > I have added the ozone changes, Please review.
> 
> Looks like you also removed the rest of ui/events/ and ui/views/ changes?

I have addressed the changes.Please review.

[d.samantaray, 2015-05-26 04:07:30]

I have incorporated all the changes in a new patch and linked to the current
issue.Please review.

[sadrul, 2015-05-26 16:56:32]

On 2015/05/26 04:07:30, d.samantaray wrote:
> I have incorporated all the changes in a new patch and linked to the current
> issue.Please review.

Can you explain if you have plans to fix up TouchNoiseFilter (the fix should be
trivial) too?

[d.samantaray, 2015-05-27 03:29:41]

On 2015/05/26 16:56:32, sadrul wrote:
> On 2015/05/26 04:07:30, d.samantaray wrote:
> > I have incorporated all the changes in a new patch and linked to the current
> > issue.Please review.
> 
> Can you explain if you have plans to fix up TouchNoiseFilter (the fix should
be
> trivial) too?

I checked and found that TouchNoiseFilter is std::vector<TouchNoiseFilter*>
filters_;So I did not go for changing this.

[d.samantaray, 2015-05-27 03:32:05]

On 2015/05/27 03:29:41, d.samantaray wrote:
> On 2015/05/26 16:56:32, sadrul wrote:
> > On 2015/05/26 04:07:30, d.samantaray wrote:
> > > I have incorporated all the changes in a new patch and linked to the
current
> > > issue.Please review.
> > 
> > Can you explain if you have plans to fix up TouchNoiseFilter (the fix should
> be
> > trivial) too?
> 
> I checked and found that TouchNoiseFilter is std::vector<TouchNoiseFilter*>
> filters_;So I did not go for changing this.

Though it is not a ScopedVector so I did not make any changes.

[sadrul, 2015-05-27 18:12:01]

lgtm

On 2015/05/27 03:32:05, d.samantaray wrote:
> On 2015/05/27 03:29:41, d.samantaray wrote:
> > On 2015/05/26 16:56:32, sadrul wrote:
> > > On 2015/05/26 04:07:30, d.samantaray wrote:
> > > > I have incorporated all the changes in a new patch and linked to the
> current
> > > > issue.Please review.
> > > 
> > > Can you explain if you have plans to fix up TouchNoiseFilter (the fix
should
> > be
> > > trivial) too?
> > 
> > I checked and found that TouchNoiseFilter is std::vector<TouchNoiseFilter*>
> > filters_;So I did not go for changing this.
> 
> Though it is not a ScopedVector so I did not make any changes.

Right. Maybe you could fix the code to use a ScopedVector instead of a
std::vector for TouchNouseFilter (in a separate CL)? Should be fairly trivial I
think.

[sadrul, 2015-05-27 18:12:08]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-05-27 18:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1138993007/80001

[commit-bot: I haz the power, 2015-05-27 19:18:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-27 19:19:18]

Patchset 5 (id:??) landed as
https://crrev.com/c1bcfae190a66a5f177542d990412b9cd48988f4
Cr-Commit-Position: refs/heads/master@{#331618}

[d.samantaray, 2015-05-28 04:08:39]

On 2015/05/27 18:12:01, sadrul wrote:
> lgtm
> 
> On 2015/05/27 03:32:05, d.samantaray wrote:
> > On 2015/05/27 03:29:41, d.samantaray wrote:
> > > On 2015/05/26 16:56:32, sadrul wrote:
> > > > On 2015/05/26 04:07:30, d.samantaray wrote:
> > > > > I have incorporated all the changes in a new patch and linked to the
> > current
> > > > > issue.Please review.
> > > > 
> > > > Can you explain if you have plans to fix up TouchNoiseFilter (the fix
> should
> > > be
> > > > trivial) too?
> > > 
> > > I checked and found that TouchNoiseFilter is
std::vector<TouchNoiseFilter*>
> > > filters_;So I did not go for changing this.
> > 
> > Though it is not a ScopedVector so I did not make any changes.
> 
> Right. Maybe you could fix the code to use a ScopedVector instead of a
> std::vector for TouchNouseFilter (in a separate CL)? Should be fairly trivial
I
> think.

Ok, I will make the changes.