ui/events/gesture_detection/motion_event_generic.cc - Issue 1138993007: Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in ui/events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/motion_event_generic.cc

Issue 1138993007: Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in ui/events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/gesture_detection/motion_event_generic.cc

diff --git a/ui/events/gesture_detection/motion_event_generic.cc b/ui/events/gesture_detection/motion_event_generic.cc

index 19262aa6e95dcc411beab127d95fd1d069bbd84a..2f2c34b11c5688bcf1c1cc3922e9f14198322ea1 100644

--- a/ui/events/gesture_detection/motion_event_generic.cc

+++ b/ui/events/gesture_detection/motion_event_generic.cc

@@ -217,7 +217,7 @@ void MotionEventGeneric::PushHistoricalEvent(scoped_ptr<MotionEvent> event) {

DCHECK_EQ(event->GetAction(), GetAction());

DCHECK_LE(event->GetEventTime().ToInternalValue(),

GetEventTime().ToInternalValue());

- historical_events_.push_back(event.release());

+ historical_events_.push_back(event.Pass());

}

MotionEventGeneric::MotionEventGeneric()

« no previous file with comments | « ui/events/gesture_detection/motion_event_buffer.cc ('k') | ui/events/gestures/gesture_provider_aura.cc » ('j') | no next file with comments »