ui/events/gestures/gesture_provider_aura.cc - Issue 1138993007: Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in ui/events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gestures/gesture_provider_aura.cc

Issue 1138993007: Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in ui/events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/gesture_detection/motion_event_generic.cc ('k') | ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gestures/gesture_provider_aura.cc

diff --git a/ui/events/gestures/gesture_provider_aura.cc b/ui/events/gestures/gesture_provider_aura.cc

index bca63f23191089f291ef720c055c805ddfcecd0d..b491a2f0b85023e85765cd299c921f553e247101 100644

--- a/ui/events/gestures/gesture_provider_aura.cc

+++ b/ui/events/gestures/gesture_provider_aura.cc

@@ -76,7 +76,7 @@ void GestureProviderAura::OnGestureEvent(

client_->OnGestureEvent(event.get());

} else {

// Memory managed by ScopedVector pending_gestures_.

- pending_gestures_.push_back(event.release());

+ pending_gestures_.push_back(event.Pass());

}