Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 1138953007: Make the snapshot a public dependency of v8. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make the snapshot a public dependency of v8. Adds a chain of public dependencies from the v8 target to the snapshot target. A future version of GN will validate that any files taken as inputs to a step were generated by public dependencies of that target. Some targets in Chrome depend on the results of the snapshot. Committed: https://crrev.com/e92804b02ecc02cb556d0b3dcf3a334987ba782a Cr-Commit-Position: refs/heads/master@{#28478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M BUILD.gn View 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
If you can, can you land this or tell me who can help? Thanks!
5 years, 7 months ago (2015-05-18 23:30:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138953007/1
5 years, 7 months ago (2015-05-18 23:55:02 UTC) #4
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 7 months ago (2015-05-18 23:55:04 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-19 11:14:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138953007/1
5 years, 7 months ago (2015-05-19 11:14:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 11:36:41 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 11:37:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e92804b02ecc02cb556d0b3dcf3a334987ba782a
Cr-Commit-Position: refs/heads/master@{#28478}

Powered by Google App Engine
This is Rietveld 408576698