Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: BUILD.gn

Issue 1138953007: Make the snapshot a public dependency of v8. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/mips.gni") 7 import("//build/config/mips.gni")
8 8
9 # Because standalone V8 builds are not supported, assume this is part of a 9 # Because standalone V8 builds are not supported, assume this is part of a
10 # Chromium build. 10 # Chromium build.
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 # depend on this. 467 # depend on this.
468 visibility = [ 468 visibility = [
469 ":*", 469 ":*",
470 "//:gn_visibility", 470 "//:gn_visibility",
471 ] 471 ]
472 472
473 deps = [ 473 deps = [
474 ":js2c", 474 ":js2c",
475 ":js2c_experimental", 475 ":js2c_experimental",
476 ":js2c_extras", 476 ":js2c_extras",
477 ":v8_base",
478 ]
479 public_deps = [
480 # This should be public so downstream targets can declare the snapshot
481 # output file as their inputs.
477 ":run_mksnapshot", 482 ":run_mksnapshot",
478 ":v8_base",
479 ] 483 ]
480 484
481 sources = [ 485 sources = [
482 "$target_gen_dir/libraries.cc", 486 "$target_gen_dir/libraries.cc",
483 "$target_gen_dir/experimental-libraries.cc", 487 "$target_gen_dir/experimental-libraries.cc",
484 "$target_gen_dir/extras-libraries.cc", 488 "$target_gen_dir/extras-libraries.cc",
485 "$target_gen_dir/snapshot.cc", 489 "$target_gen_dir/snapshot.cc",
486 ] 490 ]
487 491
488 configs -= [ "//build/config/compiler:chromium_code" ] 492 configs -= [ "//build/config/compiler:chromium_code" ]
489 configs += [ "//build/config/compiler:no_chromium_code" ] 493 configs += [ "//build/config/compiler:no_chromium_code" ]
490 configs += [ 494 configs += [
491 ":internal_config", 495 ":internal_config",
492 ":features", 496 ":features",
493 ":toolchain", 497 ":toolchain",
494 ] 498 ]
495 } 499 }
496 500
497 if (v8_use_external_startup_data) { 501 if (v8_use_external_startup_data) {
498 source_set("v8_external_snapshot") { 502 source_set("v8_external_snapshot") {
499 visibility = [ ":*" ] # Only targets in this file can depend on this. 503 visibility = [ ":*" ] # Only targets in this file can depend on this.
500 504
501 deps = [ 505 deps = [
502 ":js2c", 506 ":js2c",
503 ":js2c_experimental", 507 ":js2c_experimental",
504 ":js2c_extras", 508 ":js2c_extras",
509 ":v8_base",
510 ]
511 public_deps = [
512 ":natives_blob",
505 ":run_mksnapshot", 513 ":run_mksnapshot",
506 ":v8_base",
507 ":natives_blob",
508 ] 514 ]
509 515
510 sources = [ 516 sources = [
511 "src/snapshot/natives-external.cc", 517 "src/snapshot/natives-external.cc",
512 "src/snapshot/snapshot-external.cc", 518 "src/snapshot/snapshot-external.cc",
513 ] 519 ]
514 520
515 configs -= [ "//build/config/compiler:chromium_code" ] 521 configs -= [ "//build/config/compiler:chromium_code" ]
516 configs += [ "//build/config/compiler:no_chromium_code" ] 522 configs += [ "//build/config/compiler:no_chromium_code" ]
517 configs += [ 523 configs += [
(...skipping 1049 matching lines...) Expand 10 before | Expand all | Expand 10 after
1567 ] 1573 ]
1568 1574
1569 if (v8_use_snapshot && v8_use_external_startup_data) { 1575 if (v8_use_snapshot && v8_use_external_startup_data) {
1570 deps = [ 1576 deps = [
1571 ":v8_base", 1577 ":v8_base",
1572 ":v8_external_snapshot", 1578 ":v8_external_snapshot",
1573 ] 1579 ]
1574 } else if (v8_use_snapshot) { 1580 } else if (v8_use_snapshot) {
1575 deps = [ 1581 deps = [
1576 ":v8_base", 1582 ":v8_base",
1583 ]
1584 # v8_snapshot should be public so downstream targets can declare the
1585 # snapshot file as their input.
1586 public_deps = [
1577 ":v8_snapshot", 1587 ":v8_snapshot",
1578 ] 1588 ]
1579 } else { 1589 } else {
1580 assert(!v8_use_external_startup_data) 1590 assert(!v8_use_external_startup_data)
1581 deps = [ 1591 deps = [
1582 ":v8_base", 1592 ":v8_base",
1583 ":v8_nosnapshot", 1593 ":v8_nosnapshot",
1584 ] 1594 ]
1585 } 1595 }
1586 1596
(...skipping 15 matching lines...) Expand all
1602 } else { 1612 } else {
1603 group("v8") { 1613 group("v8") {
1604 if (v8_use_snapshot && v8_use_external_startup_data) { 1614 if (v8_use_snapshot && v8_use_external_startup_data) {
1605 deps = [ 1615 deps = [
1606 ":v8_base", 1616 ":v8_base",
1607 ":v8_external_snapshot", 1617 ":v8_external_snapshot",
1608 ] 1618 ]
1609 } else if (v8_use_snapshot) { 1619 } else if (v8_use_snapshot) {
1610 deps = [ 1620 deps = [
1611 ":v8_base", 1621 ":v8_base",
1622 ]
1623 public_deps = [
1612 ":v8_snapshot", 1624 ":v8_snapshot",
1613 ] 1625 ]
1614 } else { 1626 } else {
1615 assert(!v8_use_external_startup_data) 1627 assert(!v8_use_external_startup_data)
1616 deps = [ 1628 deps = [
1617 ":v8_base", 1629 ":v8_base",
1618 ":v8_nosnapshot", 1630 ":v8_nosnapshot",
1619 ] 1631 ]
1620 } 1632 }
1621 1633
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1663 sources += [ 1675 sources += [
1664 "src/d8-debug.cc", 1676 "src/d8-debug.cc",
1665 "$target_gen_dir/d8-js.cc", 1677 "$target_gen_dir/d8-js.cc",
1666 ] 1678 ]
1667 } 1679 }
1668 if (v8_enable_i18n_support) { 1680 if (v8_enable_i18n_support) {
1669 deps += [ "//third_party/icu" ] 1681 deps += [ "//third_party/icu" ]
1670 } 1682 }
1671 } 1683 }
1672 } 1684 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698