Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: BUILD.gn

Issue 1138953007: Make the snapshot a public dependency of v8. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 5a743606293a1edfc546cf532be2bcc1fb19634a..b045d09ffcf51352f2ff4b2f9c36a7f385598634 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -474,9 +474,13 @@ source_set("v8_snapshot") {
":js2c",
":js2c_experimental",
":js2c_extras",
- ":run_mksnapshot",
":v8_base",
]
+ public_deps = [
+ # This should be public so downstream targets can declare the snapshot
+ # output file as their inputs.
+ ":run_mksnapshot",
+ ]
sources = [
"$target_gen_dir/libraries.cc",
@@ -502,9 +506,11 @@ if (v8_use_external_startup_data) {
":js2c",
":js2c_experimental",
":js2c_extras",
- ":run_mksnapshot",
":v8_base",
+ ]
+ public_deps = [
":natives_blob",
+ ":run_mksnapshot",
]
sources = [
@@ -1574,6 +1580,10 @@ if (component_mode == "shared_library") {
} else if (v8_use_snapshot) {
deps = [
":v8_base",
+ ]
+ # v8_snapshot should be public so downstream targets can declare the
+ # snapshot file as their input.
+ public_deps = [
":v8_snapshot",
]
} else {
@@ -1609,6 +1619,8 @@ if (component_mode == "shared_library") {
} else if (v8_use_snapshot) {
deps = [
":v8_base",
+ ]
+ public_deps = [
":v8_snapshot",
]
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698