Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138263002: Revert of stop calling SkScalarDiv (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of stop calling SkScalarDiv (patchset #4 id:60001 of https://codereview.chromium.org/1135053002/) Reason for revert: need to wait for Blink roll (and patch android) Original issue's description: > stop calling SkScalarDiv > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/67d71c898249a7af3523b16c6a69895a63bfae0a TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -154 lines) Patch
M bench/GradientBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M experimental/StrokePathRenderer/GrStrokePathRenderer.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M gm/glyph_pos.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M gm/gradients.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 10 chunks +16 lines, -16 lines 0 comments Download
M gm/gradients_no_texture.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/resizeimagefilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/shaderbounds.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M gm/stringart.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkMatrix.h View 1 chunk +1 line, -7 lines 0 comments Download
M include/core/SkPoint.h View 1 chunk +0 lines, -10 lines 0 comments Download
M include/core/SkScalar.h View 1 chunk +1 line, -3 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M samplecode/SampleStringArt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimateBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimateField.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimateSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimatorScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimatorScript2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDisplayPost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDisplayable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawColor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkScriptRuntime.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkGeometry.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPathMeasure.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkPictureShader.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkRRect.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkScalar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkStroke.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M src/core/SkStrokerPriv.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkEmbossMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 5 chunks +9 lines, -7 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/svg/parser/SkSVGSVG.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M src/utils/SkInterpolator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/utils/SkNinePatch.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/MatrixTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/PathCoverageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
Created Revert of stop calling SkScalarDiv
5 years, 7 months ago (2015-05-12 17:27:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138263002/1
5 years, 7 months ago (2015-05-12 17:27:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2629697933b5cc975e45d2a45c48f803fc6cbcec
5 years, 7 months ago (2015-05-12 17:28:11 UTC) #3
reed1
5 years, 7 months ago (2015-05-12 17:36:14 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1135693003/ by reed@google.com.

The reason for reverting is: android patched, blink has rolled.

Powered by Google App Engine
This is Rietveld 408576698