src/effects/SkEmbossMaskFilter.cpp - Issue 1138263002: Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkEmbossMaskFilter.cpp

Issue 1138263002: Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkEmbossMaskFilter.cpp

diff --git a/src/effects/SkEmbossMaskFilter.cpp b/src/effects/SkEmbossMaskFilter.cpp

index 59d297835e1f9dea50e9fa629275440292beab5e..8fcd272646a4421b2f6d367d771a601f882dc04c 100644

--- a/src/effects/SkEmbossMaskFilter.cpp

+++ b/src/effects/SkEmbossMaskFilter.cpp

@@ -61,7 +61,7 @@

mag = SkScalarSqrt(mag);

for (int i = 0; i < 3; i++) {

- v[i] /= mag;

+ v[i] = SkScalarDiv(v[i], mag);

}

« no previous file with comments | « src/effects/SkDisplacementMapEffect.cpp ('k') | src/effects/SkLightingImageFilter.cpp » ('j') | no next file with comments »