Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1138073007: Nukes the windowmanager interface (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Nukes the windowmanager interface What was WindowManagerInternal* is now ViewManagerRoot*. The initial bootstrap is: . App connects to view_manager and asks for ViewManagerService. . ViewManager asks this connection for ViewManagerClient, and calls OnEmbed. . The ViewManager exposes the services ViewManagerRoot to the initial connection. All of this is handled for you if you use ViewManagerInit. As WindowManager is no more, Embed with just a url is lost. I'm assuming you'll add that back. BUG=487870 TEST=none R=ben@chromium.org Committed: https://crrev.com/6bf3a1ac1e2973e9ae382178f95fe153d021b20a Cr-Commit-Position: refs/heads/master@{#329977}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix core services #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -1092 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/BUILD.gn View 1 2 3 6 chunks +2 lines, -7 lines 0 comments Download
M components/view_manager/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/connection_manager.h View 8 chunks +11 lines, -11 lines 0 comments Download
M components/view_manager/connection_manager.cc View 1 2 3 2 chunks +6 lines, -17 lines 0 comments Download
M components/view_manager/event_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/event_dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/view_manager/public/cpp/BUILD.gn View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_client_factory.cc View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_context.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A components/view_manager/public/cpp/lib/view_manager_init.cc View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
M components/view_manager/public/cpp/view_manager_client_factory.h View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
A components/view_manager/public/cpp/view_manager_init.h View 1 chunk +50 lines, -0 lines 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + components/view_manager/public/interfaces/view_manager_root.mojom View 1 2 chunks +10 lines, -16 lines 0 comments Download
M components/view_manager/view_manager_app.h View 1 2 3 3 chunks +9 lines, -16 lines 0 comments Download
M components/view_manager/view_manager_app.cc View 1 2 3 4 chunks +15 lines, -23 lines 0 comments Download
M components/view_manager/view_manager_client_apptest.cc View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
M components/view_manager/view_manager_service_apptest.cc View 1 2 3 20 chunks +29 lines, -57 lines 0 comments Download
M components/view_manager/view_manager_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/view_manager_service_unittest.cc View 1 2 3 4 chunks +1 line, -21 lines 0 comments Download
M components/view_manager/window_manager_access_policy.cc View 1 chunk +3 lines, -1 line 0 comments Download
D components/window_manager/BUILD.gn View 1 2 3 1 chunk +0 lines, -71 lines 0 comments Download
D components/window_manager/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D components/window_manager/main.cc View 1 2 3 1 chunk +0 lines, -89 lines 0 comments Download
D components/window_manager/public/interfaces/BUILD.gn View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
D components/window_manager/public/interfaces/window_manager.mojom View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
D components/window_manager/public/interfaces/window_manager_internal.mojom View 1 chunk +0 lines, -45 lines 0 comments Download
D components/window_manager/window_manager_app.h View 1 2 3 1 chunk +0 lines, -141 lines 0 comments Download
D components/window_manager/window_manager_app.cc View 1 2 3 1 chunk +0 lines, -208 lines 0 comments Download
D components/window_manager/window_manager_apptest.cc View 1 2 3 1 chunk +0 lines, -98 lines 0 comments Download
D components/window_manager/window_manager_delegate.h View 1 2 3 1 chunk +0 lines, -32 lines 0 comments Download
D components/window_manager/window_manager_impl.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/window_manager/window_manager_impl.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M mandoline/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/browser/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/browser/browser.h View 1 2 3 5 chunks +13 lines, -11 lines 0 comments Download
M mandoline/ui/browser/browser.cc View 6 chunks +52 lines, -43 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/omnibox/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.cc View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M mojo/tools/data/apptests View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sky
5 years, 7 months ago (2015-05-14 21:31:29 UTC) #1
Ben Goodger (Google)
This is OK as an incremental improvement. LGTM
5 years, 7 months ago (2015-05-14 22:54:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138073007/40001
5 years, 7 months ago (2015-05-14 22:59:12 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/66441)
5 years, 7 months ago (2015-05-14 23:04:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138073007/60001
5 years, 7 months ago (2015-05-14 23:21:16 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-14 23:56:36 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 23:57:31 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6bf3a1ac1e2973e9ae382178f95fe153d021b20a
Cr-Commit-Position: refs/heads/master@{#329977}

Powered by Google App Engine
This is Rietveld 408576698