components/view_manager/window_manager_access_policy.cc - Issue 1138073007: Nukes the windowmanager interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/window_manager_access_policy.cc

Issue 1138073007: Nukes the windowmanager interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/window_manager_access_policy.cc

diff --git a/components/view_manager/window_manager_access_policy.cc b/components/view_manager/window_manager_access_policy.cc

index 280a73ca6a80adb659cbd0209bf4ff08a3a49a23..8581e5a22db25fc51186b0d0dcab5dff3b13f6c7 100644

--- a/components/view_manager/window_manager_access_policy.cc

+++ b/components/view_manager/window_manager_access_policy.cc

@@ -57,7 +57,9 @@ bool WindowManagerAccessPolicy::CanEmbed(const ServerView* view) const {

bool WindowManagerAccessPolicy::CanChangeViewVisibility(

const ServerView* view) const {

- return view->id().connection_id == connection_id_;

+ // The WindowManager can change the visibility of the root too.

+ return view->id().connection_id == connection_id_ ||

+ view->id() == RootViewId();

}

bool WindowManagerAccessPolicy::CanSetViewSurfaceId(