Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: components/view_manager/view_manager_client_apptest.cc

Issue 1138073007: Nukes the windowmanager interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/view_manager_client_apptest.cc
diff --git a/components/view_manager/view_manager_client_apptest.cc b/components/view_manager/view_manager_client_apptest.cc
index 54a335bca4b6f0004adabe13ee3c137cf77a8f92..9e498e2857bf68878b4ce85402cbcd42a2c6f7c7 100644
--- a/components/view_manager/view_manager_client_apptest.cc
+++ b/components/view_manager/view_manager_client_apptest.cc
@@ -13,8 +13,8 @@
#include "base/test/test_timeouts.h"
#include "components/view_manager/public/cpp/lib/view_manager_client_impl.h"
#include "components/view_manager/public/cpp/view_manager_client_factory.h"
-#include "components/view_manager/public/cpp/view_manager_context.h"
#include "components/view_manager/public/cpp/view_manager_delegate.h"
+#include "components/view_manager/public/cpp/view_manager_init.h"
#include "components/view_manager/public/cpp/view_observer.h"
#include "mojo/application/application_test_base_chromium.h"
#include "mojo/application/public/cpp/application_connection.h"
@@ -227,8 +227,8 @@ class ViewManagerTest : public test::ApplicationTestBase,
void SetUp() override {
ApplicationTestBase::SetUp();
- view_manager_context_.reset(new ViewManagerContext(application_impl()));
- view_manager_context_->Embed(application_impl()->url());
+ view_manager_init_.reset(
+ new ViewManagerInit(application_impl(), this, nullptr));
ASSERT_TRUE(DoRunLoopWithTimeout());
std::swap(window_manager_, most_recent_view_manager_);
}
@@ -236,9 +236,9 @@ class ViewManagerTest : public test::ApplicationTestBase,
// Overridden from testing::Test:
void TearDown() override { ApplicationTestBase::TearDown(); }
- scoped_ptr<ViewManagerClientFactory> view_manager_client_factory_;
+ scoped_ptr<ViewManagerInit> view_manager_init_;
- scoped_ptr<ViewManagerContext> view_manager_context_;
+ scoped_ptr<ViewManagerClientFactory> view_manager_client_factory_;
// Used to receive the most recent view manager loaded by an embed action.
ViewManager* most_recent_view_manager_;
@@ -252,7 +252,8 @@ class ViewManagerTest : public test::ApplicationTestBase,
TEST_F(ViewManagerTest, RootView) {
ASSERT_NE(nullptr, window_manager());
EXPECT_NE(nullptr, window_manager()->GetRoot());
- EXPECT_EQ("mojo:window_manager", window_manager()->GetEmbedderURL());
+ // No one embedded the window_manager(), so it has no url.
+ EXPECT_TRUE(window_manager()->GetEmbedderURL().empty());
}
TEST_F(ViewManagerTest, Embed) {
« no previous file with comments | « components/view_manager/view_manager_app.cc ('k') | components/view_manager/view_manager_service_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698