Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1137403003: Fix ChromeVox's detection of whether the current document has focus. (Closed)

Created:
5 years, 7 months ago by dmazzoni
Modified:
5 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, Greg Levin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeVox's detection of whether the current document has focus. Added a new helper function to determine whether the document has focus, taking into account whether an iframe or webview element has focus and whether the document is hidden. This fixes issues where there were two ChromeVox active indicators showing, one on the outer frame and one inside the inner frame or webview. It also fixes issues with other speech-generating events being processed in both frames at once. BUG=484904 Committed: https://crrev.com/28df096f78b61caa9fa43ae6794c89e2f6b01f82 Cr-Commit-Position: refs/heads/master@{#329956}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 8 (2 generated)
dmazzoni
5 years, 7 months ago (2015-05-14 18:33:26 UTC) #2
dmazzoni
cc: glevin
5 years, 7 months ago (2015-05-14 18:35:40 UTC) #3
David Tseng
lgtm https://codereview.chromium.org/1137403003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js (right): https://codereview.chromium.org/1137403003/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js#newcode258 chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js:258: // document isn't focused. nit: D
5 years, 7 months ago (2015-05-14 19:00:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137403003/1
5 years, 7 months ago (2015-05-14 22:29:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 22:36:19 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 22:37:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28df096f78b61caa9fa43ae6794c89e2f6b01f82
Cr-Commit-Position: refs/heads/master@{#329956}

Powered by Google App Engine
This is Rietveld 408576698