chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js - Issue 1137403003: Fix ChromeVox's detection of whether the current document has focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

Issue 1137403003: Fix ChromeVox's detection of whether the current document has focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js ('K') | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js ('k') | chrome/browser/resources/chromeos/chromevox/common/chromevox.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

index 2cb2c2efb781afb18823f713b35dd240016caa74..d4ed721a08ddcdf3a6b52b28357da18e8332b242 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

@@ -82,7 +82,7 @@ cvox.LiveRegions.nodesAlreadyHandled = [];

cvox.LiveRegions.init = function(pageLoadTime, queueMode, disableSpeak) {

cvox.LiveRegions.pageLoadTime = pageLoadTime;

- if (disableSpeak || !document.hasFocus()) {

+ if (disableSpeak || !cvox.ChromeVox.documentHasFocus()) {

return false;

}

@@ -379,7 +379,7 @@ cvox.LiveRegions.announceChange = function(

cvox.LiveRegions.lastAnnouncedMap[key] = now;

var assertive = cvox.AriaUtil.getAriaLive(liveRoot) == 'assertive';

- if (cvox.Interframe.isIframe() && !document.hasFocus()) {

+ if (cvox.Interframe.isIframe() && !cvox.ChromeVox.documentHasFocus()) {

cvox.Interframe.sendMessageToParentWindow(

{'command': 'speakLiveRegion',

'content': JSON.stringify(navDescriptions),