chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js - Issue 1137403003: Fix ChromeVox's detection of whether the current document has focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js

Issue 1137403003: Fix ChromeVox's detection of whether the current document has focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js ('K') | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js

index 3e13f57f4fc26924525accb82a321d2ed773bb94..fa1fcf63f9fcdb251ecaae8484e1331906046f95 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/initial_speech.js

@@ -62,7 +62,8 @@ cvox.InitialSpeech.speak = function() {

// actually happens inside of NavigationManager.reset, which doesn't get

// called until AbstractHost.onPageLoad, but we need to speak and braille the

// initial node here.

- if (document.hasFocus() && document.activeElement == document.body) {

+ if (cvox.ChromeVox.documentHasFocus() &&

+ document.activeElement == document.body) {

cvox.ChromeVox.navigationManager.syncToBeginning();

}

@@ -74,7 +75,7 @@ cvox.InitialSpeech.speak = function() {

}

// If this iframe has focus, speak and braille the current focused element.

- if (document.hasFocus()) {

+ if (cvox.ChromeVox.documentHasFocus()) {

if (!disableSpeak) {

cvox.ChromeVoxEventSuspender.withSuspendedEvents(function() {

cvox.ChromeVox.navigationManager.finishNavCommand(