Review Request: fix issue 8052 - Keyboard selection in Hebrew select element doesn't work

This CL fixes issue 8052 - Keyboard selection in Hebrew select element doesn't work

The fix consists of 2 parts:
The 1st part is in WebKit/WebCore/platform/chromium/PopupMenuChromimu.cpp. The patch is in https://bugs.webkit.org/show_bug.cgi?id=25899.

The 2nd part is in webkit/glue/webwidget_impl.cc:
Adding WebInputEvent::Char event type handling in WebWidgetImpl::HandleInputEvent(). The comment should be self-explained.

BUG=http://crbug.com/8052
TEST=In a HTML containing <select> tag and Hebrew character options, open the Hebrew select element, type a Hebrew letter which is the first letter of one option, that option should be selected.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16752

[Avi (use Gerrit), 2009-05-21 18:49:20]

This change looks good; waiting for the other.

[Hironori Bono, 2009-05-21 19:40:25]

LGTM with a small nit.
Thank you for your hard work.

http://codereview.chromium.org/113712/diff/1/2
File webkit/glue/webwidget_impl.cc (right):

http://codereview.chromium.org/113712/diff/1/2#newcode198
Line 198: // character value, the "selection" wont work for non-English
language,
nit: wont -> won't

[idana, 2009-05-21 19:48:22]

LGTM (with a few nits)

http://codereview.chromium.org/113712/diff/1/2
File webkit/glue/webwidget_impl.cc (right):

http://codereview.chromium.org/113712/diff/1/2#newcode196
Line 196: // language, such as Hebrew, the character value is different from
physical
"language, such as Hebrew" -> "languages, such as Hebrew"
"different from physical" -> "different from the physical"

http://codereview.chromium.org/113712/diff/1/2#newcode197
Line 197: // key value, without accepting Char event type which contains the
key's
"key value, without" -> "key value. Thus, without"

http://codereview.chromium.org/113712/diff/1/2#newcode198
Line 198: // character value, the "selection" wont work for non-English
language,
"for non-Engligh language," -> "for non-Engligh languages,"