Review Request: fix issue 8052 - Keyboard selection in Hebrew select element doesn't work

webkit/glue/webwidget_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "base/compiler_specific.h"
 
 MSVC_PUSH_WARNING_LEVEL(0);
 #include "Cursor.h"
@@ skipping 171 matching lines @@
       return true;
 
     case WebInputEvent::MouseDown:
       MouseDown(*static_cast<const WebMouseEvent*>(input_event));
       return true;
 
     case WebInputEvent::MouseUp:
       MouseUp(*static_cast<const WebMouseEvent*>(input_event));
       return true;
 
+    // In Windows, RawKeyDown only has information about the physical key, but
+    // for "selection", we need the information about the character the key
+    // translated into. For English, the physical key value and the character
+    // value are the same, hence, "selection" works for English. But for other
+    // languages, such as Hebrew, the character value is different from the
+    // physical key value. Thus, without accepting Char event type which
+    // contains the key's character value, the "selection" won't work for
+    // non-English languages, such as Hebrew.
     case WebInputEvent::RawKeyDown:
     case WebInputEvent::KeyDown:
     case WebInputEvent::KeyUp:
+    case WebInputEvent::Char:
       return KeyEvent(*static_cast<const WebKeyboardEvent*>(input_event));
 
     default:
       break;
   }
   return false;
 }
 
 void WebWidgetImpl::MouseCaptureLost() {
 }
@@ skipping 71 matching lines @@
 // WebCore::FramelessScrollViewClient
 
 void WebWidgetImpl::popupClosed(WebCore::FramelessScrollView* widget) {
   DCHECK(widget == widget_);
   if (widget_) {
     widget_->setClient(NULL);
     widget_ = NULL;
   }
   delegate_->CloseWidgetSoon(this);
 }