Review Request: fix issue 8052 - Keyboard selection in Hebrew select element doesn't work

webkit/glue/webwidget_impl.cc

Index: webkit/glue/webwidget_impl.cc
===================================================================
--- webkit/glue/webwidget_impl.cc	(revision 16549)
+++ webkit/glue/webwidget_impl.cc	(working copy)
@@ -189,9 +189,18 @@
       MouseUp(*static_cast<const WebMouseEvent*>(input_event));
       return true;
 
+    // In Windows, RawKeyDown only has information about the physical key, but
+    // for "selection", we need the information about the character the key
+    // translated into. For English, the physical key value and the character
+    // value are the same, hence, "selection" works for English. But for other
+    // languages, such as Hebrew, the character value is different from the
+    // physical key value. Thus, without accepting Char event type which
+    // contains the key's character value, the "selection" won't work for
+    // non-English languages, such as Hebrew.
     case WebInputEvent::RawKeyDown:
     case WebInputEvent::KeyDown:
     case WebInputEvent::KeyUp:
+    case WebInputEvent::Char:
       return KeyEvent(*static_cast<const WebKeyboardEvent*>(input_event));
 
     default: