Add a way to fetch window frame metrics from NativeShellWindow

chrome/browser/ui/base_window.h

Index: chrome/browser/ui/base_window.h
diff --git a/chrome/browser/ui/base_window.h b/chrome/browser/ui/base_window.h
index deaa700d549103304280f8d383dedda94f4dce6e..9c7f8653605aaeccec17d2a842d111aead86bd25 100644
--- a/chrome/browser/ui/base_window.h
+++ b/chrome/browser/ui/base_window.h
@@ -6,6 +6,7 @@
 #define CHROME_BROWSER_UI_BASE_WINDOW_H_
 
 #include "base/compiler_specific.h"
+#include "ui/gfx/insets.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace gfx {
@@ -79,6 +80,10 @@ class BaseWindow {
 
   // Returns true if a window is set to be always on top.
   virtual bool IsAlwaysOnTop() const = 0;
+
+  virtual gfx::Insets GetFrameInsets() const {
+    return gfx::Insets();
+  }

[stevenjb, 2012/11/15 18:22:47]

If we have a default implementation, we need to ensure that none of the
inheriting classes derive from any non-interface classes (i.e. no multiple
inheritance). I believe this is true.

The implementation also needs to go in a .cc file, not in the header, and the
class needs a constructor and virtual destructor.

With those conditions, I have no problem with providing a default
implementation.

[jeremya, 2012/11/16 00:12:06]

It isn't quite.
ShellWindowViews < views::WidgetDelegateView (non-interface)
ShellWindowViews < NativeShellWindow (interface) < BaseWindow

so if BaseWindow were non-interface, SWV would inherit both it and views::WDV.

Thoughts?

 };
 
 #endif  // CHROME_BROWSER_UI_BASE_WINDOW_H_