Add a way to fetch window frame metrics from NativeShellWindow

chrome/browser/ui/views/extensions/shell_window_views.cc

Index: chrome/browser/ui/views/extensions/shell_window_views.cc
diff --git a/chrome/browser/ui/views/extensions/shell_window_views.cc b/chrome/browser/ui/views/extensions/shell_window_views.cc
index 098849b03a5dc2f6c43cea45cc1d150415cd83a2..2864b475b9f76c54847f20819287f240c8cd0047 100644
--- a/chrome/browser/ui/views/extensions/shell_window_views.cc
+++ b/chrome/browser/ui/views/extensions/shell_window_views.cc
@@ -409,9 +409,8 @@ ShellWindowViews::ShellWindowViews(ShellWindow* shell_window,
   minimum_size_ = win_params.minimum_size;
   maximum_size_ = win_params.maximum_size;
   window_->Init(params);
-  gfx::Rect window_bounds =
-      window_->non_client_view()->GetWindowBoundsForClientBounds(
-          win_params.bounds);
+  gfx::Rect window_bounds = win_params.bounds;
+  window_bounds.Inset(-GetFrameInsets());

[stevenjb, 2012/11/15 18:22:47]

Even though this is more verbose, I think it is more readable.

   // Center window if no position was specified.
   if (win_params.bounds.x() == INT_MIN || win_params.bounds.y() == INT_MIN) {
     window_->CenterWindow(window_bounds.size());
@@ -574,6 +573,13 @@ bool ShellWindowViews::IsAlwaysOnTop() const {
   return false;
 }
 
+gfx::Insets ShellWindowViews::GetFrameInsets() const {
+  if (frameless())
+    return gfx::Insets();
+
+  return gfx::Insets(kCaptionHeight, 0, 0, 0);

[stevenjb, 2012/11/15 18:22:47]

And this turned out much easier to read, so I think this is a win.

+}
+
 void ShellWindowViews::DeleteDelegate() {
   shell_window_->OnNativeClose();
 }