Add a way to fetch window frame metrics from NativeShellWindow

chrome/browser/ui/base_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BASE_WINDOW_H_
 #define CHROME_BROWSER_UI_BASE_WINDOW_H_
 
 #include "base/compiler_specific.h"
+#include "ui/gfx/insets.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace gfx {
 class Rect;
 }
 
 class SkRegion;
 
 // This API needs to be implemented by any window that might be accessed
 // through chrome.windows or chrome.tabs (e.g. browser windows and panels).
@@ skipping 53 matching lines @@
 
   // Sets the window's size and position to the specified values.
   virtual void SetBounds(const gfx::Rect& bounds) = 0;
 
   // Flashes the taskbar item associated with this window.
   // Set |flash| to true to initiate flashing, false to stop flashing.
   virtual void FlashFrame(bool flash) = 0;
 
   // Returns true if a window is set to be always on top.
   virtual bool IsAlwaysOnTop() const = 0;
+
+  virtual gfx::Insets GetFrameInsets() const {
+    return gfx::Insets();
+  }

[stevenjb, 2012/11/15 18:22:47]

If we have a default implementation, we need to ensure that none of the
inheriting classes derive from any non-interface classes (i.e. no multiple
inheritance). I believe this is true.

The implementation also needs to go in a .cc file, not in the header, and the
class needs a constructor and virtual destructor.

With those conditions, I have no problem with providing a default
implementation.

[jeremya, 2012/11/16 00:12:06]

It isn't quite.
ShellWindowViews < views::WidgetDelegateView (non-interface)
ShellWindowViews < NativeShellWindow (interface) < BaseWindow

so if BaseWindow were non-interface, SWV would inherit both it and views::WDV.

Thoughts?

 };
 
 #endif  // CHROME_BROWSER_UI_BASE_WINDOW_H_