Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1136773002: Add HTTP server mojo interfaces. (Closed)

Created:
5 years, 7 months ago by yzshen1
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, jamesr, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HTTP server mojo interfaces. The reasons for adding such interfaces: - There'll be code in src/mandoline that creates an http server which enables communication between html_viewer/mandoline ui and external applications. One use case is to support telemetry. - We would like to use the C++ http server and websocket impl in net/, and don't want to link net/ into anything other than the network service. BUG=478249 TEST=None Committed: https://crrev.com/50826e07c1cad99bd1dc5984a6ea6ccdd6ddb600 Cr-Commit-Position: refs/heads/master@{#329338}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -4 lines) Patch
M mojo/services/network/network_service_impl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_impl.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M mojo/services/network/public/interfaces/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/services/network/public/interfaces/http_connection.mojom View 1 1 chunk +35 lines, -0 lines 0 comments Download
A mojo/services/network/public/interfaces/http_server.mojom View 1 chunk +12 lines, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/network_service.mojom View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
yzshen1
Hi, John: Would you please review? Thanks! This CL copies http_{request,response}.mojom from the Mojo repo; ...
5 years, 7 months ago (2015-05-08 20:52:51 UTC) #2
jam
On 2015/05/08 20:52:51, yzshen1 wrote: > Hi, > > John: Would you please review? Thanks! ...
5 years, 7 months ago (2015-05-11 14:58:40 UTC) #3
yzshen1
On 2015/05/11 14:58:40, jam wrote: > On 2015/05/08 20:52:51, yzshen1 wrote: > > Hi, > ...
5 years, 7 months ago (2015-05-11 15:38:08 UTC) #4
jam
thanks for the explanation, I wasn't sure. https://codereview.chromium.org/1136773002/diff/1/mojo/services/network/public/interfaces/http_request.mojom File mojo/services/network/public/interfaces/http_request.mojom (right): https://codereview.chromium.org/1136773002/diff/1/mojo/services/network/public/interfaces/http_request.mojom#newcode7 mojo/services/network/public/interfaces/http_request.mojom:7: struct HttpRequest ...
5 years, 7 months ago (2015-05-11 20:54:46 UTC) #5
yzshen1
https://codereview.chromium.org/1136773002/diff/1/mojo/services/network/public/interfaces/http_request.mojom File mojo/services/network/public/interfaces/http_request.mojom (right): https://codereview.chromium.org/1136773002/diff/1/mojo/services/network/public/interfaces/http_request.mojom#newcode7 mojo/services/network/public/interfaces/http_request.mojom:7: struct HttpRequest { On 2015/05/11 20:54:46, jam wrote: > ...
5 years, 7 months ago (2015-05-11 22:45:26 UTC) #6
jam
lgtm
5 years, 7 months ago (2015-05-12 01:13:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136773002/20001
5 years, 7 months ago (2015-05-12 02:24:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 03:14:49 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 03:15:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50826e07c1cad99bd1dc5984a6ea6ccdd6ddb600
Cr-Commit-Position: refs/heads/master@{#329338}

Powered by Google App Engine
This is Rietveld 408576698