mojo/services/network/public/interfaces/http_request.mojom - Issue 1136773002: Add HTTP server mojo interfaces.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/network/public/interfaces/http_request.mojom

Issue 1136773002: Add HTTP server mojo interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mojo;

	6

	7 struct HttpRequest {
	jam 2015/05/11 20:54:46 I'm curious is there a reason why we can't reuse U I'm curious is there a reason why we can't reuse URLRequest here? https://code.google.com/p/chromium/codesearch#chromium/src/mojo/services/netw.... if we can't, headers should be an array of a struct per URLRequest since there are bugs if a map is used (I just learnt this recently). same for response yzshen1 2015/05/11 22:45:26 Good point. Thanks! Show quoted text On 2015/05/11 20:54:46, jam wrote: > I'm curious is there a reason why we can't reuse URLRequest here? > https://code.google.com/p/chromium/codesearch#chromium/src/mojo/services/netw.... > > if we can't, headers should be an array of a struct per URLRequest since there > are bugs if a map is used (I just learnt this recently). same for response Good point. Thanks!
	8 string relative_url; // Starts with '/'. Example: "/test?query=foo"

	9

	10 // The HTTP method if applicable.

	11 string method = "GET";

	12

	13 // Additional HTTP request headers.

	14 map<string, string>? headers;

	15

	16 // The payload for the request body. Only set for "POST" or "PUT".

	17 handle<data_pipe_consumer>? body;

	18 };

OLD	NEW