Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136593004: Add a simple browser UI (with url bar) (Closed)

Created:
5 years, 7 months ago by Ben Goodger (Google)
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a simple browser UI (with url bar) R=sky@chromium.org BUG= Committed: https://crrev.com/67837e39863ff7d690585e94f1bb1a6f95bcec23 Cr-Commit-Position: refs/heads/master@{#329000}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -140 lines) Patch
M mandoline/ui/BUILD.gn View 1 1 chunk +3 lines, -6 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 4 chunks +3 lines, -12 lines 0 comments Download
A mandoline/ui/aura/input_method_mandoline.h View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A mandoline/ui/aura/input_method_mandoline.cc View 1 chunk +77 lines, -0 lines 0 comments Download
D mandoline/ui/aura/input_method_mojo_linux.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mandoline/ui/aura/input_method_mojo_linux.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M mandoline/ui/aura/native_widget_view_manager.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M mandoline/ui/aura/surface_context_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/aura/surface_context_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mandoline/ui/browser/BUILD.gn View 1 2 2 chunks +17 lines, -3 lines 0 comments Download
M mandoline/ui/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A mandoline/ui/browser/android/android_ui.h View 1 chunk +36 lines, -0 lines 0 comments Download
A mandoline/ui/browser/android/android_ui.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M mandoline/ui/browser/browser.h View 5 chunks +5 lines, -8 lines 0 comments Download
M mandoline/ui/browser/browser.cc View 1 2 6 chunks +10 lines, -13 lines 0 comments Download
A mandoline/ui/browser/browser_ui.h View 1 chunk +29 lines, -0 lines 0 comments Download
A mandoline/ui/browser/desktop/desktop_ui.h View 1 chunk +53 lines, -0 lines 0 comments Download
A mandoline/ui/browser/desktop/desktop_ui.cc View 1 2 3 4 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Ben Goodger (Google)
5 years, 7 months ago (2015-05-07 22:50:07 UTC) #1
sky
LGTM https://codereview.chromium.org/1136593004/diff/20001/mandoline/ui/browser/BUILD.gn File mandoline/ui/browser/BUILD.gn (right): https://codereview.chromium.org/1136593004/diff/20001/mandoline/ui/browser/BUILD.gn#newcode24 mandoline/ui/browser/BUILD.gn:24: if (is_android) { nit: combine with if (!is_android) ...
5 years, 7 months ago (2015-05-07 23:07:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136593004/60001
5 years, 7 months ago (2015-05-08 17:58:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136593004/80001
5 years, 7 months ago (2015-05-08 18:17:55 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-08 18:57:29 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 18:58:47 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/67837e39863ff7d690585e94f1bb1a6f95bcec23
Cr-Commit-Position: refs/heads/master@{#329000}

Powered by Google App Engine
This is Rietveld 408576698