Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 113653006: Remove complexity related to m_cachedElementsArrayOffset from LiveNodeListBase (Closed)

Created:
7 years ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove complexity related to m_cachedElementsArrayOffset from LiveNodeListBase Remove complexity related to m_cachedElementsArrayOffset from LiveNodeListBase and HTMLCollection. The complexity is moved to HTMLFormControlsCollection which is the only type that actually needs to cache this offset. The code in LiveNodeListBase / HTMLCollection is overly complex and this is one step towards improving the situation. This change is a partial merge of WebKit r158758 by <antti@apple.com>;. R=abarth, esprehn, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164452

Patch Set 1 #

Patch Set 2 : Move invalidateIdNameCacheMaps to HTMLCollection #

Patch Set 3 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -69 lines) Patch
M Source/core/dom/LiveNodeList.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 2 1 chunk +1 line, -10 lines 1 comment Download
M Source/core/html/HTMLCollection.h View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 2 8 chunks +24 lines, -35 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 2 chunks +37 lines, -9 lines 0 comments Download
M Source/core/html/HTMLNameCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLNameCollection.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years ago (2013-12-20 21:14:32 UTC) #1
Inactive
Post-holidays ping review? :)
6 years, 11 months ago (2014-01-03 15:50:05 UTC) #2
eseidel
lgtm https://codereview.chromium.org/113653006/diff/170001/Source/core/dom/LiveNodeList.cpp File Source/core/dom/LiveNodeList.cpp (right): https://codereview.chromium.org/113653006/diff/170001/Source/core/dom/LiveNodeList.cpp#newcode57 Source/core/dom/LiveNodeList.cpp:57: static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps(); Bleh.
6 years, 11 months ago (2014-01-03 17:45:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/113653006/170001
6 years, 11 months ago (2014-01-03 17:45:05 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-03 17:52:18 UTC) #5
Message was sent while issue was closed.
Change committed as 164452

Powered by Google App Engine
This is Rietveld 408576698