Source/core/dom/LiveNodeList.cpp - Issue 113653006: Remove complexity related to m_cachedElementsArrayOffset from LiveNodeListBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/LiveNodeList.cpp

Issue 113653006: Remove complexity related to m_cachedElementsArrayOffset from LiveNodeListBase (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/LiveNodeList.cpp

diff --git a/Source/core/dom/LiveNodeList.cpp b/Source/core/dom/LiveNodeList.cpp

index 4e437fa60fd0fa287616a2537526b9bf725cc387..9c664b6b8f0ce6dd06b0e69919c3e5adf10e86a7 100644

--- a/Source/core/dom/LiveNodeList.cpp

+++ b/Source/core/dom/LiveNodeList.cpp

@@ -49,21 +49,12 @@ void LiveNodeListBase::invalidateCache() const

m_isLengthCacheValid = false;

m_isItemCacheValid = false;

m_isNameCacheValid = false;

- if (isNodeList(type()))

- return;

- const HTMLCollection* cacheBase = static_cast<const HTMLCollection*>(this);

- cacheBase->m_idCache.clear();

- cacheBase->m_nameCache.clear();

- cacheBase->m_cachedElementsArrayOffset = 0;

}

void LiveNodeListBase::invalidateIdNameCacheMaps() const

{

ASSERT(hasIdNameCache());

- const HTMLCollection* cacheBase = static_cast<const HTMLCollection*>(this);

- cacheBase->m_idCache.clear();

- cacheBase->m_nameCache.clear();

+ static_cast<const HTMLCollection*>(this)->invalidateIdNameCacheMaps();

eseidel 2014/01/03 17:45:00 Bleh.

}

Node* LiveNodeList::namedItem(const AtomicString& elementId) const

« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/html/HTMLCollection.h » ('j') | no next file with comments »