Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: Source/core/dom/LiveNodeList.h

Issue 113653006: Remove complexity related to m_cachedElementsArrayOffset from LiveNodeListBase (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/LiveNodeList.cpp » ('j') | Source/core/dom/LiveNodeList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/LiveNodeList.h
diff --git a/Source/core/dom/LiveNodeList.h b/Source/core/dom/LiveNodeList.h
index 4c3e2d5b6e804bff1464294b5ff17134be6cd649..c84c648a03ccaf5666abec6ab8598a2690e96219 100644
--- a/Source/core/dom/LiveNodeList.h
+++ b/Source/core/dom/LiveNodeList.h
@@ -91,8 +91,7 @@ public:
else if (hasIdNameCache() && (*attrName == HTMLNames::idAttr || *attrName == HTMLNames::nameAttr))
invalidateIdNameCacheMaps();
}
- void invalidateCache() const;
- void invalidateIdNameCacheMaps() const;
+ virtual void invalidateCache() const;
static bool shouldInvalidateTypeOnAttributeChange(NodeListInvalidationType, const QualifiedName&);
@@ -120,7 +119,6 @@ protected:
m_cachedItemOffset = offset;
m_isItemCacheValid = true;
}
- void setItemCache(Node* item, unsigned offset, unsigned elementsArrayOffset) const;
ALWAYS_INLINE NodeListRootType rootType() const { return static_cast<NodeListRootType>(m_rootType); }
@@ -138,6 +136,7 @@ private:
bool isFirstItemCloserThanCachedItem(unsigned offset) const;
Node* iterateForPreviousNode(Node* current) const;
Node* itemBefore(Node* previousItem) const;
+ void invalidateIdNameCacheMaps() const;
RefPtr<Node> m_ownerNode;
mutable Node* m_cachedItem;
« no previous file with comments | « no previous file | Source/core/dom/LiveNodeList.cpp » ('j') | Source/core/dom/LiveNodeList.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698