Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 11364221: Fixing RenderingStats vs WebRenderingStats mess (Closed)

Created:
8 years, 1 month ago by hartmanng
Modified:
8 years ago
Reviewers:
Ian Vollick, jamesr, nduca
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Fixing RenderingStats vs WebRenderingStats mess We'd like to not have to plumb stats through the WebKit public API, as briefly mentioned here https://bugs.webkit.org/show_bug.cgi?id=101629 . This patch should creates a WebRenderingStatsImpl containing a RenderingStats, and downcasts it to send it through WebKit. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169513

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -39 lines) Patch
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 2 3 2 chunks +25 lines, -14 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 2 chunks +15 lines, -7 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.cc View 1 2 3 2 chunks +3 lines, -14 lines 0 comments Download
A webkit/compositor_bindings/web_rendering_stats_impl.h View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Ian Vollick
I think it looks great. I only have a few nits, but Nat should probably ...
8 years, 1 month ago (2012-11-13 21:26:06 UTC) #1
hartmanng
This should get around WebRenderingStats so we don't need to keep modifying the WebKit public ...
8 years, 1 month ago (2012-11-13 21:42:53 UTC) #2
jamesr
https://codereview.chromium.org/11364221/diff/9002/webkit/compositor_bindings/web_layer_tree_view_impl.h File webkit/compositor_bindings/web_layer_tree_view_impl.h (right): https://codereview.chromium.org/11364221/diff/9002/webkit/compositor_bindings/web_layer_tree_view_impl.h#newcode54 webkit/compositor_bindings/web_layer_tree_view_impl.h:54: virtual void renderingStats(void*) const OVERRIDE; How is this better ...
8 years, 1 month ago (2012-11-13 21:44:53 UTC) #3
jamesr
The real way to fix this is to have the gpu benchmark extension code have ...
8 years, 1 month ago (2012-11-13 22:03:56 UTC) #4
hartmanng
If I understood our IM conversation last night, I believe this is the approach we ...
8 years, 1 month ago (2012-11-14 16:06:28 UTC) #5
nduca
@jamesr for review. if he's happy, go ahead. Im too slammed to review.
8 years, 1 month ago (2012-11-14 20:51:39 UTC) #6
jamesr
Can you send this to the 'win' trybot to make sure it compiles in that ...
8 years, 1 month ago (2012-11-14 21:43:02 UTC) #7
jamesr
Assuming you can get this to compile + link everywhere, the approach seems fine.
8 years, 1 month ago (2012-11-14 21:43:57 UTC) #8
hartmanng
Having trouble running trybots, they all seem to fail immediately with "Failure -1" and no ...
8 years, 1 month ago (2012-11-15 14:06:23 UTC) #9
hartmanng
On 2012/11/15 14:06:23, hartmanng wrote: > Having trouble running trybots, they all seem to fail ...
8 years, 1 month ago (2012-11-15 21:02:07 UTC) #10
Ian Vollick
On 2012/11/15 21:02:07, hartmanng wrote: > On 2012/11/15 14:06:23, hartmanng wrote: > > Having trouble ...
8 years, 1 month ago (2012-11-21 14:22:03 UTC) #11
nduca
how're we doing on this, glenn?
8 years, 1 month ago (2012-11-23 22:35:57 UTC) #12
hartmanng
On 2012/11/23 22:35:57, nduca wrote: > how're we doing on this, glenn? blocked on thanksgiving ...
8 years, 1 month ago (2012-11-23 22:38:02 UTC) #13
jamesr
lgtm
8 years ago (2012-11-26 20:00:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11364221/6006
8 years ago (2012-11-26 20:01:50 UTC) #15
commit-bot: I haz the power
8 years ago (2012-11-26 22:37:45 UTC) #16
Message was sent while issue was closed.
Change committed as 169513

Powered by Google App Engine
This is Rietveld 408576698