Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 11364040: Merge 133011 - Calendar picker can flicker when opened from the suggestion picker (Closed)

Created:
8 years, 1 month ago by keishi
Modified:
8 years, 1 month ago
Reviewers:
keishi
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133011 - Calendar picker can flicker when opened from the suggestion picker https://bugs.webkit.org/show_bug.cgi?id=100816 Reviewed by Kent Tamura. Source/WebCore: Calendar picker was opening before the hiding completed. No new tests. Added test to date-suggestion-picker-key-operations.html. * Resources/pagepopups/pickerCommon.js: Added didHide event. * Resources/pagepopups/suggestionPicker.js: (SuggestionPicker.prototype.selectEntry): Use didHide event so we don't open the calendar picker prematurely. (SuggestionPicker._handleWindowDidHide): When the window finished hiding, open the calendar picker. LayoutTests: * fast/forms/resources/picker-common.js: (openPicker): Fix mistake. * platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt: * platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt: * platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html: Test that didHide event fires after the entry was selected and before the calendar picker opened. TBR=keishi@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133257

Patch Set 1 #

Messages

Total messages: 1 (0 generated)
keishi
8 years, 1 month ago (2012-11-02 02:20:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698