Source/WebCore/ChangeLog - Issue 11364040: Merge 133011 - Calendar picker can flicker when opened from the suggestion picker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/ChangeLog

Issue 11364040: Merge 133011 - Calendar picker can flicker when opened from the suggestion picker (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « LayoutTests/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt ('k') | Source/WebCore/Resources/pagepopups/pickerCommon.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/ChangeLog

===================================================================

--- Source/WebCore/ChangeLog (revision 133256)

+++ Source/WebCore/ChangeLog (working copy)

@@ -1,3 +1,19 @@

+2012-10-31 Keishi Hattori <keishi@webkit.org>

+ Calendar picker can flicker when opened from the suggestion picker

+ https://bugs.webkit.org/show_bug.cgi?id=100816

+ Reviewed by Kent Tamura.

+ Calendar picker was opening before the hiding completed.

+ No new tests. Added test to date-suggestion-picker-key-operations.html.

+ * Resources/pagepopups/pickerCommon.js: Added didHide event.

+ * Resources/pagepopups/suggestionPicker.js:

+ (SuggestionPicker.prototype.selectEntry): Use didHide event so we don't open the calendar picker prematurely.

+ (SuggestionPicker._handleWindowDidHide): When the window finished hiding, open the calendar picker.

2012-09-19 Dan Bernstein <mitz@apple.com>

When kerning is enabled, word spacing is doubly accounted for in RenderText::computePreferredLogicalWidths