[Password Manager] Improve signature of PasswordManagerClient::IsPasswordSyncEnabled

[Password Manager] Improve signature of PasswordManagerClient::IsPasswordSyncEnabled

Currently, IsPasswordSyncEnabled needs to know if the caller is interested in syncing passwords with a custom passphrase or without, and returns a Boolean depending on whether the expected syncing occurs or not.

This CL gets rid of the need to pass the expectation, and changes the Boolean return value to say: no password sync, p.s. without a custom passphrase, or p.s. with a custom passphrase. It also changes the name of the method and the associated enum to make sense with the new signature.

This is a cosmetic change, but will make a subsequent CL easier to digest.

R=melandory@chromium.org

BUG=400674, 486739
Committed: https://crrev.com/c885020e9b1a3523cd5682c53d69f4d6b499249e
Cr-Commit-Position: refs/heads/master@{#329637}

[vabr (Chromium), 2015-05-13 12:34:53]

Hi Tanja,

Could you please take a look?

Thanks!
Vaclav

[vabr (Chromium), 2015-05-13 12:53:59]

Ah, now I see the iOS failure. I'll fix it.

Cheers,
Vaclav

[vabr (Chromium), 2015-05-13 12:55:39]

On 2015/05/13 12:53:59, vabr (Chromium) wrote:
> Ah, now I see the iOS failure. I'll fix it.
> 
> Cheers,
> Vaclav

Actually, it is not an iOS failure, just iOS was the quickest to build. Fixing
now.

Cheers,
Vaclav

[melandory, 2015-05-13 13:19:11]

lgtm with remark.

https://codereview.chromium.org/1136403002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_manager_client.h (right):

https://codereview.chromium.org/1136403002/diff/20001/components/password_man...
components/password_manager/core/browser/password_manager_client.h:30:
SYNCING_WITH_CUSTOM_PASSPHRASE
nit: it's easy to accidentally use wrong state and didn't notice, because
WITHOUT and WITH are too similar (maybe it's just non native speaker problem,
but I had to pay some extra attention to check if correct one is used).
Unfortunately, I can't suggest anything better :(

[vabr (Chromium), 2015-05-13 13:23:45]

I'll upload a new patch set momentarily.
Thanks!
Vaclav

https://codereview.chromium.org/1136403002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_manager_client.h (right):

https://codereview.chromium.org/1136403002/diff/20001/components/password_man...
components/password_manager/core/browser/password_manager_client.h:30:
SYNCING_WITH_CUSTOM_PASSPHRASE
On 2015/05/13 13:19:11, melandory wrote:
> nit: it's easy to accidentally use wrong state and didn't notice, because
> WITHOUT and WITH are too similar (maybe it's just non native speaker problem,
> but I had to pay some extra attention to check if correct one is used).
> Unfortunately, I can't suggest anything better :(

Thanks for mentioning this. I was not sure myself, but given you feel that way
too, I'll change that as follows:
SYNCING_WITHOUT_CUSTOM_PASSPHRASE -> SYNCING_NORMAL_ENCRYPTION

Does that look good?

[melandory, 2015-05-13 13:34:07]

On 2015/05/13 13:23:45, vabr (Chromium) wrote:
> I'll upload a new patch set momentarily.
> Thanks!
> Vaclav
> 
>
https://codereview.chromium.org/1136403002/diff/20001/components/password_man...
> File components/password_manager/core/browser/password_manager_client.h
(right):
> 
>
https://codereview.chromium.org/1136403002/diff/20001/components/password_man...
> components/password_manager/core/browser/password_manager_client.h:30:
> SYNCING_WITH_CUSTOM_PASSPHRASE
> On 2015/05/13 13:19:11, melandory wrote:
> > nit: it's easy to accidentally use wrong state and didn't notice, because
> > WITHOUT and WITH are too similar (maybe it's just non native speaker
problem,
> > but I had to pay some extra attention to check if correct one is used).
> > Unfortunately, I can't suggest anything better :(
> 
> Thanks for mentioning this. I was not sure myself, but given you feel that way
> too, I'll change that as follows:
> SYNCING_WITHOUT_CUSTOM_PASSPHRASE -> SYNCING_NORMAL_ENCRYPTION
Yep, much better.

[vabr (Chromium), 2015-05-13 13:39:03]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-05-13 13:39:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
melandory@chromium.org
Link to the patchset: https://codereview.chromium.org/1136403002/#ps40001
(title: "SYNCING_NORMAL_ENCRYPTION")

[commit-bot: I haz the power, 2015-05-13 13:39:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136403002/40001

[commit-bot: I haz the power, 2015-05-13 15:08:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-13 15:09:48]

Patchset 3 (id:??) landed as
https://crrev.com/c885020e9b1a3523cd5682c53d69f4d6b499249e
Cr-Commit-Position: refs/heads/master@{#329637}