components/password_manager/core/browser/password_generation_manager.cc - Issue 1136403002: [Password Manager] Improve signature of PasswordManagerClient::IsPasswordSyncEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager.cc

Issue 1136403002: [Password Manager] Improve signature of PasswordManagerClient::IsPasswordSyncEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SYNCING_NORMAL_ENCRYPTION Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | components/password_manager/core/browser/password_generation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager.cc

diff --git a/components/password_manager/core/browser/password_generation_manager.cc b/components/password_manager/core/browser/password_generation_manager.cc

index fcb9f0af03d88113b94a610c7d3ce22bad2b10a1..59e9f8d10e086111807498f7de57a50f0acaa975 100644

--- a/components/password_manager/core/browser/password_generation_manager.cc

+++ b/components/password_manager/core/browser/password_generation_manager.cc

@@ -57,8 +57,8 @@ bool PasswordGenerationManager::IsGenerationEnabled() const {

}

// Don't consider sync enabled if the user has a custom passphrase. See

- // crbug.com/358998 for more details.

- if (!client_->IsPasswordSyncEnabled(WITHOUT_CUSTOM_PASSPHRASE)) {

+ // http://crbug.com/358998 for more details.

+ if (client_->GetPasswordSyncState() != SYNCING_NORMAL_ENCRYPTION) {

VLOG(2) << "Generation disabled because passwords are not being synced or"

<< " custom passphrase is used.";

return false;