Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 1136403002: [Password Manager] Improve signature of PasswordManagerClient::IsPasswordSyncEnabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SYNCING_NORMAL_ENCRYPTION Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index fce9293115650f6a4ea58b13941686bda1d07bf9..0309454f0909aed10ed50891123618e9e56bbe1b 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -24,9 +24,10 @@ class PasswordManager;
class PasswordManagerDriver;
class PasswordStore;
-enum CustomPassphraseState {
- WITHOUT_CUSTOM_PASSPHRASE,
- ONLY_CUSTOM_PASSPHRASE
+enum PasswordSyncState {
+ NOT_SYNCING_PASSWORDS,
+ SYNCING_NORMAL_ENCRYPTION,
+ SYNCING_WITH_CUSTOM_PASSPHRASE
};
enum class CredentialSourceType {
@@ -125,10 +126,9 @@ class PasswordManagerClient {
// Returns the PasswordStore associated with this instance.
virtual PasswordStore* GetPasswordStore() const = 0;
- // Returns true if password sync is enabled in the embedder. Return value for
- // custom passphrase users depends on |state|. The default implementation
- // always returns false.
- virtual bool IsPasswordSyncEnabled(CustomPassphraseState state) const;
+ // Reports whether and how passwords are synced in the embedder. The default
+ // implementation always returns NOT_SYNCING_PASSWORDS.
+ virtual PasswordSyncState GetPasswordSyncState() const;
// Only for clients which registered with a LogRouter: If called with
// |router_can_be_used| set to false, the client may no longer use the

Powered by Google App Engine
This is Rietveld 408576698