Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1136273002: Convert cr-settings-menu to Polymer 0.8 (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 7 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@AddPaperItem
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert cr-settings-menu to Polymer 0.8 BUG=485381 Committed: https://crrev.com/6408b3cbc02360177679104c8626a1fde50431f4 Cr-Commit-Position: refs/heads/master@{#329552}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Switch to paper-menu #

Patch Set 3 : rebase. license. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -65 lines) Patch
A chrome/browser/resources/settings/settings_menu/settings_menu.css View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 1 chunk +15 lines, -17 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 1 chunk +15 lines, -18 lines 0 comments Download
D chrome/browser/resources/settings/settings_menu/settings_menu_style.html View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
michaelpg
5 years, 7 months ago (2015-05-12 15:03:11 UTC) #2
Jeremy Klein
https://codereview.chromium.org/1136273002/diff/1/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/1136273002/diff/1/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode6 chrome/browser/resources/settings/settings_menu/settings_menu.html:6: <link rel="import" href="chrome://resources/polymer/v0_8/paper-styles/paper-styles.html"> Where is this used? https://codereview.chromium.org/1136273002/diff/1/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode11 chrome/browser/resources/settings/settings_menu/settings_menu.html:11: ...
5 years, 7 months ago (2015-05-12 18:27:04 UTC) #3
michaelpg
https://codereview.chromium.org/1136273002/diff/1/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/1136273002/diff/1/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode6 chrome/browser/resources/settings/settings_menu/settings_menu.html:6: <link rel="import" href="chrome://resources/polymer/v0_8/paper-styles/paper-styles.html"> On 2015/05/12 18:27:04, Jeremy Klein wrote: ...
5 years, 7 months ago (2015-05-12 19:27:08 UTC) #5
Jeremy Klein
lgtm
5 years, 7 months ago (2015-05-12 20:28:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136273002/60001
5 years, 7 months ago (2015-05-12 20:56:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/58216)
5 years, 7 months ago (2015-05-12 21:47:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136273002/60001
5 years, 7 months ago (2015-05-12 22:30:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63160)
5 years, 7 months ago (2015-05-12 22:36:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136273002/80001
5 years, 7 months ago (2015-05-13 00:16:19 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 7 months ago (2015-05-13 01:13:47 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 01:14:39 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6408b3cbc02360177679104c8626a1fde50431f4
Cr-Commit-Position: refs/heads/master@{#329552}

Powered by Google App Engine
This is Rietveld 408576698