Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 1136273002: Convert cr-settings-menu to Polymer 0.8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@AddPaperItem
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index ec2108a9e00f50041aba437abd64d9ec9a2a35cb..acb05046f5d9757f1a405a3e015d28877e033f8c 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -8,35 +8,32 @@
*
* Example:
*
- * <cr-settings-menu pages="{{pages}}" selectedId="{{selectedId}}">
+ * <cr-settings-menu pages="[[pages]]" selected-id="{{selectedId}}">
* </cr-settings-menu>
*
* @group Chrome Settings Elements
* @element cr-settings-menu
*/
-Polymer('cr-settings-menu', {
- publish: {
+Polymer({
+ is: 'cr-settings-menu',
+
+ properties: {
/**
* Pages to show menu items for.
- *
- * @attribute pages
- * @type Array<!Object>
- * @default null
+ * @type {!Array<!HTMLElement>}
*/
- pages: null,
+ pages: {
+ type: Array,
+ value: function() { return []; },
+ },
/**
* ID of the currently selected page.
- *
- * @attribute selectedId
- * @type string
- * default ''
*/
- selectedId: '',
- },
-
- /** @override */
- created: function() {
- this.pages = [];
+ selectedId: {
+ type: String,
+ value: '',
+ notify: true,
+ },
},
});

Powered by Google App Engine
This is Rietveld 408576698