chrome/browser/resources/settings/settings_menu/settings_menu.html - Issue 1136273002: Convert cr-settings-menu to Polymer 0.8

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1136273002: Convert cr-settings-menu to Polymer 0.8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@AddPaperItem

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.css ('k') | chrome/browser/resources/settings/settings_menu/settings_menu.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">	1 <link rel="import" href="chrome://resources/polymer/v0_8/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">	2 <link rel="import" href="chrome://resources/polymer/v0_8/iron-icon/iron-icon.htm l">

3 <link rel="import" href="settings_menu_style.html">	3 <link rel="import" href="chrome://resources/polymer/v0_8/iron-icons/iron-icons.h tml">

	4 <link rel="import" href="chrome://resources/polymer/v0_8/iron-selector/iron-sele ctor.html">

	5 <link rel="import" href="chrome://resources/polymer/v0_8/paper-item/paper-icon-i tem.html">

	6 <link rel="import" href="chrome://resources/polymer/v0_8/paper-styles/paper-styl es.html">
	Jeremy Klein 2015/05/12 18:27:04 Where is this used? Where is this used? michaelpg 2015/05/12 19:27:08 oops, isn't Show quoted text On 2015/05/12 18:27:04, Jeremy Klein wrote: > Where is this used? oops, isn't
4	7

5 <polymer-element name="cr-settings-menu">	8 <dom-module id="cr-settings-menu">

	9 <link rel="import" type="css" href="settings_menu.css">

6 <template>	10 <template>

7 <core-style ref="settingsMenuStyle"></core-style>	11 <iron-selector selected="{{selectedId}}" attr-for-selected="data-id">
	Jeremy Klein 2015/05/12 18:27:04 Should this be a paper-menu when that cl lands? Should this be a paper-menu when that cl lands? michaelpg 2015/05/12 19:27:08 Yes, they just published 0.8.3 which works as expe Show quoted text On 2015/05/12 18:27:04, Jeremy Klein wrote: > Should this be a paper-menu when that cl lands? Yes, they just published 0.8.3 which works as expected.
8 <!-- TODO(jlklein): selectedAttribute here is a workaround for	12 <template is="x-repeat" items="[[pages]]">

9 https://github.com/Polymer/polymer/issues/946. Remove when core-menu	13 <paper-icon-item data-id$="[[item.PAGE_ID]]" icon-width="34px">

10 is updated. -->	14 <iron-icon icon="[[item.icon]]" item-icon></iron-icon>

11 <core-menu selected="{{selectedId}}" valueattr="data-id"	15 <span>[[item.pageTitle]]</span>

12 selectedAttribute="">

13 <template repeat="{{pages}}">

14 <paper-item data-id="{{PAGE_ID}}">

15 <core-icon icon="{{icon}}"></core-icon>

16 {{pageTitle}}

17 </paper-item>	16 </paper-item>

18 </template>	17 </template>

19 </core-menu>	18 </iron-selector>

20 </template>	19 </template>

21 <script src="settings_menu.js"></script>	20 <script src="settings_menu.js"></script>

22 </polymer-element>	21 </dom-module>

OLD	NEW