Chromium Code Reviews
Help | Chromium Project | Sign in
(315)

Issue 11362051: ninja/mac: Let copies sections that copy stuff inside a bundle mark the bundle as dirty. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Nico
Modified:
2 years, 6 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com, Mark Mentovai - out til August
Visibility:
Public.

Description

ninja/mac: Let copies sections that copy stuff inside a bundle mark the bundle as dirty. BUG=chromium:157077 gyp r1533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M pylib/gyp/generator/ninja.py View 3 chunks +11 lines, -2 lines 0 comments Download
M test/mac/gyptest-postbuild-copy-bundle.py View 2 chunks +13 lines, -0 lines 0 comments Download
A test/mac/postbuild-copy-bundle/copied.txt View 1 chunk +1 line, -0 lines 0 comments Download
M test/mac/postbuild-copy-bundle/test.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Nico
Somewhat yucky, but the current gyp bundle syntax doesn't offer a non-yucky way to copy ...
2 years, 6 months ago (2012-11-07 00:20:24 UTC) #1
scottmg
2 years, 6 months ago (2012-11-07 00:27:57 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be