Chromium Code Reviews
Help | Chromium Project | Sign in
(172)

Issue 11362051: ninja/mac: Let copies sections that copy stuff inside a bundle mark the bundle as dirty. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Nico
Modified:
1 year, 5 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com, Mark Mentovai
Visibility:
Public.

Description

ninja/mac: Let copies sections that copy stuff inside a bundle mark the bundle as dirty.

BUG=chromium:157077
gyp r1533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Lint Patch
M pylib/gyp/generator/ninja.py View 3 chunks +11 lines, -2 lines 0 comments 0 errors Download
M test/mac/gyptest-postbuild-copy-bundle.py View 2 chunks +13 lines, -0 lines 0 comments 0 errors Download
A test/mac/postbuild-copy-bundle/copied.txt View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M test/mac/postbuild-copy-bundle/test.gyp View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Nico
Somewhat yucky, but the current gyp bundle syntax doesn't offer a non-yucky way to copy ...
1 year, 5 months ago #1
scottmg
1 year, 5 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6