Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: test/mac/gyptest-postbuild-copy-bundle.py

Issue 11362051: ninja/mac: Let copies sections that copy stuff inside a bundle mark the bundle as dirty. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/mac/postbuild-copy-bundle/copied.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mac/gyptest-postbuild-copy-bundle.py
===================================================================
--- test/mac/gyptest-postbuild-copy-bundle.py (revision 1529)
+++ test/mac/gyptest-postbuild-copy-bundle.py (working copy)
@@ -26,6 +26,9 @@
app_bundle_dir, 'Contents', 'My Framework.framework', 'Resources')
final_plist_path = os.path.join(bundled_framework_dir, 'Info.plist')
final_resource_path = os.path.join(bundled_framework_dir, 'resource_file.sb')
+ final_copies_path = os.path.join(
+ app_bundle_dir, 'Contents', 'My Framework.framework', 'Versions', 'A',
+ 'Libraries', 'copied.txt')
# Check that the dependency was built and copied into the app bundle:
test.build('test.gyp', 'test_app', chdir=CHDIR)
@@ -59,4 +62,14 @@
\t<key>RandomKey</key>
\t<string>NewRandomValue</string>''')
+ # Check the same for the copies section, test for http://crbug.com/157077
+ test.sleep()
+ contents = test.read('postbuild-copy-bundle/copied.txt')
+ contents = contents.replace('old', 'new')
+ test.write('postbuild-copy-bundle/copied.txt', contents)
+ test.build('test.gyp', 'test_app', chdir=CHDIR)
+
+ test.must_exist(final_copies_path)
+ test.must_contain(final_copies_path, 'new copied file')
+
test.pass_test()
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/mac/postbuild-copy-bundle/copied.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698