Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chromeos/network/shill_property_handler.cc

Issue 11361274: Add NetworkStateListDetailedView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix clang warning Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/shill_property_handler.cc
diff --git a/chromeos/network/shill_property_handler.cc b/chromeos/network/shill_property_handler.cc
index e9050899d54c53fdd274b212ca71fb0768f609f1..b2dc56e77fa5bc626f38681c8bd14d970f69a615 100644
--- a/chromeos/network/shill_property_handler.cc
+++ b/chromeos/network/shill_property_handler.cc
@@ -151,11 +151,10 @@ bool ShillPropertyHandler::ManagerPropertyChanged(const std::string& key,
bool notify_manager_changed = false;
if (key == flimflam::kServicesProperty) {
const base::ListValue* vlist = GetListValue(key, value);
- if (vlist)
- UpdateManagedList(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
- } else if (key == flimflam::kServiceWatchListProperty) {
- const base::ListValue* vlist = GetListValue(key, value);
if (vlist) {
+ UpdateManagedList(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
+ // TODO(stevenjb): Use kServiceWatchListProperty and request properties
gauravsh 2012/11/27 20:48:09 Any reason why you got rid of the service watch li
stevenjb 2012/11/27 22:19:19 I can put this in a separate CL and implement it c
+ // for new entries.
UpdateObservedNetworkServices(*vlist);
}
} else if (key == flimflam::kDevicesProperty) {

Powered by Google App Engine
This is Rietveld 408576698