Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: chromeos/network/shill_property_handler_unittest.cc

Issue 11361274: Add NetworkStateListDetailedView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix clang warning Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/shill_property_handler_unittest.cc
diff --git a/chromeos/network/shill_property_handler_unittest.cc b/chromeos/network/shill_property_handler_unittest.cc
index f9954d69067bbd9a3048a0ae068c5fcf99eb7518..7e449115bd2c182759cce46bfc5318d1cdff3dc8 100644
--- a/chromeos/network/shill_property_handler_unittest.cc
+++ b/chromeos/network/shill_property_handler_unittest.cc
@@ -329,27 +329,7 @@ TEST_F(ShillPropertyHandlerTest, ShillPropertyHandlerServicePropertyChanged) {
scan_interval,
base::Bind(&base::DoNothing), base::Bind(&ErrorCallbackFunction));
message_loop_.RunUntilIdle();
- // Property change should NOT trigger an update.
- EXPECT_EQ(0, listener_->
- property_updates(flimflam::kServicesProperty)[kTestServicePath]);
-
- // Add the existing service to the watch list.
- AddService(flimflam::kTypeWifi, kTestServicePath,
- flimflam::kStateIdle, true);
- message_loop_.RunUntilIdle();
- // No new updates or services:
- EXPECT_EQ(1, listener_->manager_updates());
- EXPECT_EQ(2, listener_->list_updates(flimflam::kServicesProperty));
- EXPECT_EQ(kNumShillManagerClientStubImplServices + 1,
- listener_->entries(flimflam::kServicesProperty).size());
- // Change a property.
- DBusThreadManager::Get()->GetShillServiceClient()->SetProperty(
- dbus::ObjectPath(kTestServicePath),
- flimflam::kScanIntervalProperty,
- scan_interval,
- base::Bind(&base::DoNothing), base::Bind(&ErrorCallbackFunction));
- message_loop_.RunUntilIdle();
- // Property change SHOULD trigger an update.
+ // Property change should trigger an update.
EXPECT_EQ(1, listener_->
property_updates(flimflam::kServicesProperty)[kTestServicePath]);
« chromeos/network/shill_property_handler.cc ('K') | « chromeos/network/shill_property_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698