Add NetworkStateListDetailedView

chromeos/network/shill_property_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/shill_property_handler.h"
 
 #include "base/bind.h"
 #include "base/format_macros.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
@@ skipping 133 matching lines @@
   }
   if (notify)
     listener_->ManagerPropertyChanged();
 }
 
 bool ShillPropertyHandler::ManagerPropertyChanged(const std::string& key,
                                                   const base::Value& value) {
   bool notify_manager_changed = false;
   if (key == flimflam::kServicesProperty) {
     const base::ListValue* vlist = GetListValue(key, value);
-    if (vlist)
+    if (vlist) {
       UpdateManagedList(ManagedState::MANAGED_TYPE_NETWORK, *vlist);
-  } else if (key == flimflam::kServiceWatchListProperty) {
-    const base::ListValue* vlist = GetListValue(key, value);
-    if (vlist) {
+      // TODO(stevenjb): Use kServiceWatchListProperty and request properties

[gauravsh, 2012/11/27 20:48:09]

Any reason why you got rid of the service watch list handling? Can this be part
of a separate CL?

[stevenjb, 2012/11/27 22:19:19]

I can put this in a separate CL and implement it correctly. This was an easier
fix to get the code working.

+      // for new entries.
       UpdateObservedNetworkServices(*vlist);
     }
   } else if (key == flimflam::kDevicesProperty) {
     const ListValue* vlist = GetListValue(key, value);
     if (vlist)
       UpdateManagedList(ManagedState::MANAGED_TYPE_DEVICE, *vlist);
   } else if (key == flimflam::kAvailableTechnologiesProperty) {
     const base::ListValue* vlist = GetListValue(key, value);
     if (vlist) {
       listener_->UpdateAvailableTechnologies(*vlist);
@@ skipping 109 matching lines @@
   if (!properties.GetStringWithoutPathExpansion(flimflam::kAddressProperty,
                                                 &ip_address)) {
     LOG(ERROR) << "Failed to get IP Address property for: " << service_path;
     return;
   }
   listener_->UpdateNetworkServiceIPAddress(service_path, ip_address);
 }
 
 }  // namespace internal
 }  // namespace chromeos